-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update scala #253
update scala #253
Conversation
Thanks @davidmargolin!! Also, feel free to add yourself to our Letting travis to its thing :) |
looks like more than i thought... switching to WIP |
@davidmargolin we haven't linked to profiles yet. If you add yourself to AUTHORS, you can do a link to your github profile if you wish. I may add mine as well. It really is an individual choice. |
Interesting on the build failure, one of them succeeded and the other failed? I may just rebuild that one, perhaps some travis cache woes? |
May even need to clear out the travis caches on a scala update, unsure |
@davidmargolin try updating the version in .travis.yml too |
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 95.12% 95.14% +0.01%
==========================================
Files 123 123
Lines 4859 4858 -1
Branches 106 105 -1
==========================================
Hits 4622 4622
+ Misses 237 236 -1
Continue to review full report at Codecov.
|
It maybe possible also that the new scala version is finding a few unused things in our code
Build Output
|
Confirmed, same thing happens locally. The adjustments I mentioned above worked. @davidmargolin willing to make those changes ⬆️ in my last comment and post an update to the PR. No unit tests or anything else need to be made. Let me know if you have any questions. |
I fixed the initial ones locally, and there are sooo many more. Apologies @davidmargolin thought this would be simpler. Squashing the compiler warnings is annoying |
@davidmargolin feel free to hop in the gitter channel if you need any assistance. I think there are maybe about a dozen compiler warnings that need to be fixed as part of this upgrade. We will be happy to help out with anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, I think everything else is good
modules/api/src/test/scala/vinyldns/api/domain/batch/BatchChangeServiceSpec.scala
Show resolved
Hide resolved
finally haha. Thanks for the opportunity and the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thanks a lot for your help @davidmargolin!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran this locally, looks good!
Updates scala to 2.12.7
resolves #251