Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CNAME alias doesn't allow forward slashes for forward zones #849

Closed
mitruly opened this issue Sep 24, 2019 · 1 comment · Fixed by #1134
Closed

Validate CNAME alias doesn't allow forward slashes for forward zones #849

mitruly opened this issue Sep 24, 2019 · 1 comment · Fixed by #1134
Assignees
Labels
area/api Items relating to the API

Comments

@mitruly
Copy link
Contributor

mitruly commented Sep 24, 2019

We currently use the same validation regex for host names that we do for input names as we do CNAME data (including allowing of /). The issue is that only CNAMEs in reverse zones (e.g. zones in the form of x.x.x.in-addr.arpa. or x.x.x.x.ip6.arpa.) should be allowed to have /; forward slashes should not be allowed in forward zones.


Good candidate files for changes:

  • Update validations: BatchChangeValidations.scala and RecordSetValidations
  • Add unit tests: BatchChangeValidationsSpec.scala
  • Add end-to-end tests: create_batch_change_test.py
@mitruly mitruly added hacktoberfest area/api Items relating to the API labels Sep 24, 2019
@mitruly mitruly changed the title Validate CNAME alias doesn't contain invalid data Validate CNAME alias doesn't allow forward slashes for forward zones Sep 27, 2019
@pauljamescleary
Copy link
Contributor

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants