Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forward slash validation for forward and reverse zone #1134

Merged
merged 11 commits into from Sep 13, 2022

Conversation

Jay07GIT
Copy link
Member

Fixes #849.

Changes in this pull request:

  • Added forward slash validation in CNAME for forward and reverse zone

@Jay07GIT Jay07GIT self-assigned this May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Base: 92.09% // Head: 92.10% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (55b319e) compared to base (ce716a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   92.09%   92.10%   +0.01%     
==========================================
  Files         172      172              
  Lines        6954     6968      +14     
  Branches      161      156       -5     
==========================================
+ Hits         6404     6418      +14     
  Misses        550      550              
Impacted Files Coverage Δ
...scala/vinyldns/core/domain/SingleChangeError.scala 100.00% <ø> (ø)
.../scala/vinyldns/api/domain/DomainValidations.scala 100.00% <100.00%> (ø)
...ldns/api/domain/batch/BatchChangeValidations.scala 97.76% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jay07GIT Jay07GIT added kind/bug Something isn't working area/core Items relating to core functionality which may not be directly related to API or Portal behavior labels May 24, 2022
@remerle remerle added this to the vNext milestone May 25, 2022
Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nspadaccino nspadaccino merged commit fe61181 into vinyldns:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Items relating to core functionality which may not be directly related to API or Portal behavior kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate CNAME alias doesn't allow forward slashes for forward zones
4 participants