Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded limits changed as configurable. #1052

Merged
merged 19 commits into from
Feb 7, 2022

Conversation

Jay07GIT
Copy link
Member

@Jay07GIT Jay07GIT commented Sep 29, 2021

Fixes #974

Changes in this pull request:

  • Changed the hardcoded limits to configurable from reference.conf
  • This changes belongs to only Membership(groups).

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2021

CLA assistant check
All committers have signed the CLA.

@Jay07GIT
Copy link
Member Author

Completed changes for batch change, zone , recordset for limits as configurable.

@Jay07GIT Jay07GIT force-pushed the hardcoded-limits branch 3 times, most recently from f968f83 to 202a18f Compare November 18, 2021 14:07
@Jay07GIT Jay07GIT force-pushed the hardcoded-limits branch 2 times, most recently from 69da159 to 919dba9 Compare November 18, 2021 14:50
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1052 (656955f) into master (d7497e3) will decrease coverage by 0.09%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   92.71%   92.61%   -0.10%     
==========================================
  Files         169      170       +1     
  Lines        6682     6700      +18     
  Branches      163      152      -11     
==========================================
+ Hits         6195     6205      +10     
- Misses        487      495       +8     
Impacted Files Coverage Δ
modules/api/src/main/scala/vinyldns/api/Boot.scala 0.00% <0.00%> (ø)
...ain/scala/vinyldns/api/route/VinylDNSService.scala 0.00% <ø> (ø)
.../main/scala/vinyldns/api/config/LimitsConfig.scala 100.00% <100.00%> (ø)
...ain/scala/vinyldns/api/config/VinylDNSConfig.scala 100.00% <100.00%> (ø)
.../scala/vinyldns/api/route/BatchChangeRouting.scala 86.15% <100.00%> (ø)
...n/scala/vinyldns/api/route/MembershipRouting.scala 99.02% <100.00%> (ø)
...in/scala/vinyldns/api/route/RecordSetRouting.scala 97.11% <100.00%> (ø)
...rc/main/scala/vinyldns/api/route/ZoneRouting.scala 97.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e8fe7...656955f. Read the comment docs.

@remerle remerle added area/core Items relating to core functionality which may not be directly related to API or Portal behavior area/api Items relating to the API kind/maintenance Code cleanup, refactoring, upgrading to new shiny things status/ready the issue is ready to be worked on and prioritized and removed area/core Items relating to core functionality which may not be directly related to API or Portal behavior labels Dec 22, 2021
@remerle remerle added this to the vNext milestone Dec 22, 2021
Copy link
Member

@remerle remerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remerle remerle merged commit 74bde43 into vinyldns:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API kind/maintenance Code cleanup, refactoring, upgrading to new shiny things status/ready the issue is ready to be worked on and prioritized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hard-coded limits with configuration
3 participants