Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to search groups #1053

Merged
merged 6 commits into from
Feb 1, 2022
Merged

Add the ability to search groups #1053

merged 6 commits into from
Feb 1, 2022

Conversation

Aravindh-Raju
Copy link
Member

@Aravindh-Raju Aravindh-Raju commented Oct 4, 2021 •
edited

Fixes #603

Changes in this pull request:

  • Added search/filter functionality to groups (Similar to how the search in the Zones view functions.)
  • This is addressed as a part of Replace the portal #968

@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited

Codecov Report

Merging #1053 (dfe4ffb) into master (b8ad28a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         169      169           
  Lines        6670     6670           
  Branches      167      167           
=======================================
  Hits         6183     6183           
  Misses        487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ee0c9...dfe4ffb. Read the comment docs.

@Aravindh-Raju Aravindh-Raju changed the title Add the ability to search/filter groups Add the ability to search groups Jan 10, 2022
@remerle
Copy link
Member

remerle commented Jan 31, 2022

@Aravindh-Raju Can you update this PR. It's currently out-of-date.

@Aravindh-Raju
Copy link
Member Author

@Aravindh-Raju Can you update this PR. It's currently out-of-date.

Updated the PR to latest master. Checked the working locally once again and it works as expected. Able to search groups. (Similar to how the search in the Zones view functions.)

@remerle remerle added area/portal Items relating to the Portal kind/enhancement A modification or enhancement to existing functionality status/ready the issue is ready to be worked on and prioritized labels Feb 1, 2022
@remerle remerle added this to the vNext milestone Feb 1, 2022
remerle
remerle approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@remerle remerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remerle remerle merged commit 0726e96 into vinyldns:master Feb 1, 2022
@Aravindh-Raju Aravindh-Raju deleted the aravindhr/group-search-filter branch March 9, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remerle remerle remerle approved these changes

Assignees

@Aravindh-Raju Aravindh-Raju

Labels
area/portal Items relating to the Portal kind/enhancement A modification or enhancement to existing functionality status/ready the issue is ready to be worked on and prioritized
Projects
None yet
Milestone
0.10.5
Development

Successfully merging this pull request may close these issues.

Ability to search/filter Groups by keyword
2 participants
@Aravindh-Raju @remerle