Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain atomicity in membership service #1081

Merged

Conversation

Aravindh-Raju
Copy link
Member

Changes in this pull request:

  • Created a transaction to maintain atomicity in MembershipService.scala where group, groupChange, membership data are changed without a tranaction. Now, either everything gets executed or none gets executed.
  • Verified the transaction by running locally.

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1081 (a201bd8) into master (fb9bd16) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   92.69%   92.70%           
=======================================
  Files         169      169           
  Lines        6670     6676    +6     
  Branches      167      163    -4     
=======================================
+ Hits         6183     6189    +6     
  Misses        487      487           
Impacted Files Coverage Δ
...core/domain/membership/GroupChangeRepository.scala 0.00% <ø> (ø)
...ldns/api/domain/membership/MembershipService.scala 94.65% <100.00%> (+0.25%) ⬆️
.../mysql/repository/MySqlGroupChangeRepository.scala 100.00% <100.00%> (ø)
...nyldns/mysql/repository/MySqlGroupRepository.scala 100.00% <100.00%> (ø)
...s/mysql/repository/MySqlMembershipRepository.scala 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9bd16...a201bd8. Read the comment docs.

Copy link
Member

@remerle remerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remerle remerle added area/db Items relating to data or the database kind/maintenance Code cleanup, refactoring, upgrading to new shiny things labels Jan 31, 2022
@remerle remerle added this to the vNext milestone Jan 31, 2022
@remerle remerle merged commit e237190 into vinyldns:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db Items relating to data or the database kind/maintenance Code cleanup, refactoring, upgrading to new shiny things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants