Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make menu bars fixed #1116

Merged
merged 2 commits into from Aug 30, 2022
Merged

Make menu bars fixed #1116

merged 2 commits into from Aug 30, 2022

Conversation

Aravindh-Raju
Copy link
Member

Fixes #959

Changes in this pull request:

  • Made the top and left menu bars fixed so it is visible all the time even when we scroll a view.

@Aravindh-Raju Aravindh-Raju self-assigned this Apr 27, 2022
@Aravindh-Raju Aravindh-Raju added area/ui-ux Items pertaining to UI and UX kind/bug Something isn't working labels Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022 •
edited

Codecov Report

Merging #1116 (7e8e7ec) into master (89ecce2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         172      172           
  Lines        6945     6945           
  Branches      158      158           
=======================================
  Hits         6396     6396           
  Misses        549      549

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72976c8...7e8e7ec. Read the comment docs.

Jay07GIT
Jay07GIT approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@Jay07GIT Jay07GIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

nspadaccino
nspadaccino approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@remerle remerle added this to the vNext milestone May 25, 2022
remerle
remerle approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@remerle remerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

arpit4ever
arpit4ever approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit4ever arpit4ever merged commit d14ef31 into vinyldns:master Aug 30, 2022
@Aravindh-Raju Aravindh-Raju mentioned this pull request Sep 12, 2022
Merged
nspadaccino added a commit that referenced this pull request Sep 12, 2022
@nspadaccino
Merge pull request #1179 from Aravindh-Raju/aravindhr/menu-bar-bug-fix
7f9f4ee 
PR #1116 Bug Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remerle remerle remerle approved these changes

@arpit4ever arpit4ever arpit4ever approved these changes

@nspadaccino nspadaccino nspadaccino approved these changes

@Jay07GIT Jay07GIT Jay07GIT approved these changes

Assignees

@Aravindh-Raju Aravindh-Raju

Labels
area/ui-ux Items pertaining to UI and UX kind/bug Something isn't working
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

fix the left and top menu bars from scrolling
5 participants
@Aravindh-Raju @remerle @arpit4ever @nspadaccino @Jay07GIT