Validate Group Fields in API #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.09% // Head: 92.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 92.09% 92.09% -0.01%
==========================================
Files 172 172
Lines 6945 6954 +9
Branches 158 161 +3
==========================================
+ Hits 6396 6404 +8
- Misses 549 550 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Aravindh-Raju
added
kind/bug
remerle
previously requested changes
May 25, 2022
modules/api/src/main/scala/vinyldns/api/domain/membership/MembershipService.scala
Outdated
Show resolved
Hide resolved
nspadaccino
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1120.
Changes in this pull request:
nameand/oremailfields empty. Now we cannot create a group with emptynameand/oremailfields through API and we'll get the messageGroup name and email cannot be empty.when either or both is empty.