Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for safari issue in autocomplete search #1182

Merged
merged 3 commits into from Sep 15, 2022

Conversation

Jay07GIT
Copy link
Member

@Jay07GIT Jay07GIT commented Sep 15, 2022

Fixes #1183.

Changes in this pull request:

  • Fix for autocomplete recordset and group search feature, where safari browser not set the value selected in auto complete dropdown.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 92.10% // Head: 92.10% // No change to project coverage 👍

Coverage data is based on head (e9a0063) compared to base (c223dc6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         172      172           
  Lines        6968     6968           
  Branches      155      155           
=======================================
  Hits         6418     6418           
  Misses        550      550           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jay07GIT Jay07GIT self-assigned this Sep 15, 2022
@Jay07GIT Jay07GIT added kind/bug Something isn't working area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX labels Sep 15, 2022
Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, autocomplete for records and groups is working in safari, chrome, and firefox

@nspadaccino nspadaccino merged commit d21d25f into vinyldns:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete search not set the selected value in the text box while search in safari browser.
3 participants