Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional NAPTR validations #1260

Conversation

Aravindh-Raju
Copy link
Member

Fixes #1259.

Changes in this pull request:

  • Added additional validations for NAPTR flags and regexp.

@Aravindh-Raju Aravindh-Raju self-assigned this May 30, 2023
@Aravindh-Raju Aravindh-Raju added kind/enhancement A modification or enhancement to existing functionality area/api Items relating to the API labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5a5a9fd) 91.97% compared to head (839b683) 91.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1260   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         176      176           
  Lines        7625     7627    +2     
  Branches      234      235    +1     
=======================================
+ Hits         7013     7015    +2     
  Misses        612      612           
Impacted Files Coverage Δ
...ain/scala/vinyldns/api/route/DnsJsonProtocol.scala 99.19% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nspadaccino nspadaccino merged commit 9fb33d5 into vinyldns:master May 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API kind/enhancement A modification or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validations for NAPTR regexp and flags
3 participants