Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Option to Filter Out PTR Zones in the Zones View #1274

Merged

Conversation

nspadaccino
Copy link
Member

Fixes #1122

A checkbox option to filter out PTR zones has been added in the zones view. This filter will still apply when searching for zone names

@nspadaccino nspadaccino self-assigned this Jul 5, 2023
@nspadaccino nspadaccino added kind/enhancement A modification or enhancement to existing functionality area/portal Items relating to the Portal area/api Items relating to the API labels Jul 5, 2023
@arpit4ever arpit4ever added this to the v0.19.0 milestone Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 90.62% and project coverage change: -0.02 ⚠️

Comparison is base (b40b7d6) 92.26% compared to head (47f6a7b) 92.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   92.26%   92.24%   -0.02%     
==========================================
  Files         176      176              
  Lines        7663     7682      +19     
  Branches      223      227       +4     
==========================================
+ Hits         7070     7086      +16     
- Misses        593      596       +3     
Impacted Files Coverage Δ
.../scala/vinyldns/api/domain/zone/ZoneProtocol.scala 97.67% <ø> (ø)
...ala/vinyldns/core/domain/zone/ZoneRepository.scala 100.00% <ø> (ø)
...inyldns/mysql/repository/MySqlZoneRepository.scala 95.76% <81.25%> (-1.35%) ⬇️
...n/scala/vinyldns/api/domain/zone/ZoneService.scala 97.07% <100.00%> (+0.03%) ⬆️
...rc/main/scala/vinyldns/api/route/ZoneRouting.scala 97.14% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@JoshSEdwards JoshSEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One thing to note is, when we paginate, the styling kind of overlaps between the checkboxes and pagination button as attached in the screenshot below. We can fix that in a separate PR maybe in the next release.

Screenshot 2023-07-06 at 11 02 26 AM

Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit4ever arpit4ever merged commit dcfcf67 into vinyldns:master Jul 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API area/portal Items relating to the Portal kind/enhancement A modification or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide PTR zones from zone list by default
4 participants