Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal UI Changes -- Issue #1280 #1282

Merged

Conversation

Aravindh-Raju
Copy link
Member

Fixes #1280.

Changes in this pull request:

@Aravindh-Raju Aravindh-Raju self-assigned this Jul 24, 2023
@Aravindh-Raju Aravindh-Raju added area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a6b320e) 92.22% compared to head (ed6d40a) 92.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1282   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         176      176           
  Lines        7767     7767           
  Branches      230      230           
=======================================
  Hits         7163     7163           
  Misses        604      604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nspadaccino
Copy link
Member

#1280 (comment)
Accidentally posted my comment on the issue and not the PR

@Aravindh-Raju
Copy link
Member Author

Aravindh-Raju commented Aug 2, 2023

#1280 (comment) Accidentally posted my comment on the issue and not the PR

Done with the changes.

Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nspadaccino nspadaccino merged commit fd3893c into vinyldns:master Aug 9, 2023
4 checks passed
@arpit4ever arpit4ever changed the title Portal UI Changes Portal UI Changes -- Issue #1280 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal UI Changes
3 participants