list abandoned zones

[Jay07GIT]

Fixes #617

Changes in this pull request:

• Added API for deleted zones history (zones/deleted/changes)
• Made Portal changes to view deleted zones history.
• Removed Cascade from zone_access table. We use this on comparing zone_change table .
• Added zone_status column in zone_access table to identify the deleted zones and used the same in deleting the group.

[codecov]

Codecov Report

Patch coverage is 91.57% of modified lines.

Files Changed	Coverage
...ldns/api/domain/zone/ListZoneChangesResponse.scala	ø
.../scala/vinyldns/api/domain/zone/ZoneProtocol.scala	0.00%
...s/mysql/repository/MySqlZoneChangeRepository.scala	87.50%
modules/portal/app/controllers/VinylDNS.scala	87.50%
...n/scala/vinyldns/api/domain/zone/ZoneService.scala	95.65%
...rc/main/scala/vinyldns/api/route/ZoneRouting.scala	100.00%
...inyldns/mysql/repository/MySqlZoneRepository.scala	100.00%

📢 Thoughts on this report? Let us know!.

[arpit4ever]

LGTM
Tested (GUI & API) functionality locally.

[nspadaccino]

I'm seeing a bug in the zones view.
If I log in as one user, create a group, and connect a zone, then log in with another user not in that group, I am able to see the zone in My Zones, and I am able to click on it. When I click on it, I get a 403 error (since that user doesn't have permission to view that private zone).

Other groups' private zones shouldn't appear in My Zones tab

[nspadaccino]

Also, it seems like wildcard search isn't working correctly for abandoned zones.
In My Zones, I can search for "o*" and see the zone "ok". But when I search for "o*" in abandoned zones, I get no results.

[Jay07GIT]

Also, it seems like wildcard search isn't working correctly for abandoned zones. In My Zones, I can search for "o*" and see the zone "ok". But when I search for "o*" in abandoned zones, I get no results.

Yes. its right . Since we used scala filter we dont need wildcard for seach. we can jus give "o" to search ok. zones.

[Jay07GIT]

I'm seeing a bug in the zones view. If I log in as one user, create a group, and connect a zone, then log in with another user not in that group, I am able to see the zone in My Zones, and I am able to click on it. When I click on it, I get a 403 error (since that user doesn't have permission to view that private zone). Other groups' private zones shouldn't appear in My Zones tab

Oh yes. Updated the code. Now its working fine.

[arpit4ever]

LGTM

[nspadaccino]

looks good