Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added zone id in recordset change failure metrics api parameters #1288

Merged

Conversation

Jay07GIT
Copy link
Member

@Jay07GIT Jay07GIT commented Aug 2, 2023

Fixes #1290 .

Changes in this pull request:

  • Added zone id as a parameter in recordset change failure metrics api.

@Jay07GIT Jay07GIT self-assigned this Aug 2, 2023
@Jay07GIT Jay07GIT added the area/api Items relating to the API label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e6a1ec) 92.22% compared to head (ae18bd1) 92.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1288   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         176      176           
  Lines        7768     7768           
  Branches      236      230    -6     
=======================================
  Hits         7164     7164           
  Misses        604      604           
Files Changed Coverage Δ
.../vinyldns/api/domain/record/RecordSetService.scala 93.10% <100.00%> (ø)
...in/scala/vinyldns/api/route/RecordSetRouting.scala 97.77% <100.00%> (ø)
...mysql/repository/MySqlRecordChangeRepository.scala 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good to me

Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nspadaccino nspadaccino merged commit 1e96bb7 into vinyldns:master Aug 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zoneid filter in the recordset change failure metrics
3 participants