Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collapse fix in manage records #1294

Merged
merged 4 commits into from
Sep 12, 2023
Merged

collapse fix in manage records #1294

merged 4 commits into from
Sep 12, 2023

Conversation

Jay07GIT
Copy link
Member

@Jay07GIT Jay07GIT commented Aug 22, 2023 •
edited

Fixes #1297.

Changes in this pull request:

  • collapse fix for manage records in zones view page.

@Jay07GIT Jay07GIT self-assigned this Aug 22, 2023
@Jay07GIT Jay07GIT added area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@arpit4ever arpit4ever added this to the v0.19.2 milestone Aug 24, 2023
Aravindh-Raju
Aravindh-Raju approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Looks good to me!

arpit4ever
arpit4ever previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nspadaccino
nspadaccino reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, but when I hover my cursor over the collapse button, it doesn't give any indication that it is clickable. Is that possible to add?

@Jay07GIT
Copy link
Member Author

Jay07GIT commented Sep 9, 2023

Functionality looks good, but when I hover my cursor over the collapse button, it doesn't give any indication that it is clickable. Is that possible to add?

Sure. I added the mouse over for the indication.

arpit4ever
arpit4ever approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nspadaccino nspadaccino merged commit 6a57199 into vinyldns:master Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpit4ever arpit4ever arpit4ever approved these changes

@nspadaccino nspadaccino nspadaccino approved these changes

@Aravindh-Raju Aravindh-Raju Aravindh-Raju approved these changes

@ssranjani06 ssranjani06 Awaiting requested review from ssranjani06

@JoshSEdwards JoshSEdwards Awaiting requested review from JoshSEdwards

Assignees

@Jay07GIT Jay07GIT

Labels
area/portal Items relating to the Portal area/ui-ux Items pertaining to UI and UX
Projects
None yet
Milestone
v0.19.2
Development

Successfully merging this pull request may close these issues.

Portal UI Fixes- Collapse the Recent Record Changes is not working in zone page.
4 participants
@Jay07GIT @arpit4ever @nspadaccino @Aravindh-Raju