New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display action buttons if there's ACL access #1320
Display action buttons if there's ACL access #1320
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for private zones, but for shared zones the change makes the buttons available for all unowned records. When we opened up the ability to view shared zones to all users, we kept it so that they wouldn't be able to update or delete records from that view #1162.
If we want to stick with that choice, then if a group has an ACL granting delete access for just A records in a shared zone, they should just see the buttons for A records. Same goes for ACL on a specific record mask.
However, maybe this is something we want to change. Maybe limiting access to the update and delete buttons in shared zones is too restrictive?
I've made changes to hide the action buttons in shared zones for now. We shall discuss things we want to do about shared zones as discussed and open a separate PR for that. |
Created issue #1322 to show buttons in shared zones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
9e0aba7
to
1f07093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good, ACL rules are making the proper buttons show up in private zones, and users can now edit and delete unowned records in shared zones directly via zone view
Fixes #1316 and #1322.
Changes in this pull request:
Update
andDelete
buttons in Zones view when a user has Write and Delete ACL rules applied. Only theUpdate
button will be displayed if there's onlyWrite
ACL rule. BothUpdate
andDelete
will be displayed if there'sDelete
ACL rule.