Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group id in user response #1328

Merged
merged 6 commits into from Feb 21, 2024
Merged

Conversation

Jay07GIT
Copy link
Member

@Jay07GIT Jay07GIT commented Nov 8, 2023

Fixes #1334.

Changes in this pull request:

  • Added group id in user details response API.

@Jay07GIT Jay07GIT self-assigned this Jan 8, 2024
@Jay07GIT Jay07GIT added the area/api Items relating to the API label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8192780) 92.06% compared to head (b759016) 92.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.03%     
==========================================
  Files         177      177              
  Lines        7911     7915       +4     
  Branches      260      236      -24     
==========================================
+ Hits         7283     7285       +2     
- Misses        628      630       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should be added. Looks good otherwise while tested locally!

@nspadaccino nspadaccino added this to the v0.20.0 milestone Feb 7, 2024
Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, users route is returning groups list as expected. Would we also be able to add the groups info to the users/lookupuser route?

Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nspadaccino nspadaccino merged commit 6210e12 into vinyldns:master Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UserId field in User details response API
4 participants