New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add group id in user response #1328
Conversation
modules/api/src/main/scala/vinyldns/api/domain/membership/MembershipService.scala
Outdated
Show resolved
Hide resolved
modules/api/src/main/scala/vinyldns/api/domain/membership/MembershipService.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 92.06% 92.04% -0.03%
==========================================
Files 177 177
Lines 7911 7915 +4
Branches 260 236 -24
==========================================
+ Hits 7283 7285 +2
- Misses 628 630 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test should be added. Looks good otherwise while tested locally!
modules/api/src/main/scala/vinyldns/api/domain/membership/MembershipService.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, users route is returning groups list as expected. Would we also be able to add the groups info to the users/lookupuser
route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1334.
Changes in this pull request: