updated filter deleted zones using scala to sql query #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay07GIT
requested review from
Aravindh-Raju,
nspadaccino,
ssranjani06 and
JoshSEdwards
Aravindh-Raju
suggested changes
Nov 21, 2023
modules/mysql/src/main/resources/db/migration/V3.31__AddZoneChangeFields.sql
Outdated
Show resolved
Hide resolved
modules/mysql/src/main/scala/vinyldns/mysql/repository/MySqlZoneChangeRepository.scala
Outdated
Show resolved
Hide resolved
modules/mysql/src/main/scala/vinyldns/mysql/repository/MySqlZoneChangeRepository.scala
Outdated
Show resolved
Hide resolved
modules/mysql/src/main/scala/vinyldns/mysql/repository/MySqlZoneChangeRepository.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 92.05% 92.03% -0.02%
==========================================
Files 177 177
Lines 7904 7911 +7
Branches 231 241 +10
==========================================
+ Hits 7276 7281 +5
- Misses 628 630 +2 ☔ View full report in Codecov by Sentry. |
JoshSEdwards
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1330.
Changes in this pull request: