Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide zone change for users not in admin group #1333

Merged

Conversation

Aravindh-Raju
Copy link
Member

Fixes #1332

Changes in this pull request:

  • Hidden zone change history for non-members in portal. Made restrictions to not access zone change history through api for users of the zone who are not part of the zone's admin group or a support/super user.

@Aravindh-Raju Aravindh-Raju self-assigned this Dec 12, 2023
@Aravindh-Raju Aravindh-Raju added area/api Items relating to the API area/portal Items relating to the Portal labels Dec 12, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (2bfc0e3) to head (7e8c436).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         177      177           
  Lines        7915     7918    +3     
  Branches      236      239    +3     
=======================================
+ Hits         7287     7290    +3     
  Misses        628      628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nspadaccino
Copy link
Member

Currently normal users aren't able to access private zones owned by other groups in the portal and API at all, so this change may be redundant

@Aravindh-Raju
Copy link
Member Author

Currently normal users aren't able to access private zones owned by other groups in the portal and API at all, so this change may be redundant

This is for users who have ACL rules applied. Even if they are applied a read only ACL rule, they can still see zone details and zone changes while they should only see records and record changes and not anything related to zones. As ACL rules are only for records and even with delete ACL rule applied they can't make any changes to zones. So I thought of hiding those from them.

@arpit4ever arpit4ever added this to the v0.20.0 milestone Feb 13, 2024
Copy link
Contributor

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nspadaccino nspadaccino merged commit 3a68cc6 into vinyldns:master Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API area/portal Items relating to the Portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide zone change for users not in admin group
3 participants