New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide zone change for users not in admin group #1333
Hide zone change for users not in admin group #1333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 177 177
Lines 7915 7918 +3
Branches 236 239 +3
=======================================
+ Hits 7287 7290 +3
Misses 628 628 ☔ View full report in Codecov by Sentry. |
Currently normal users aren't able to access private zones owned by other groups in the portal and API at all, so this change may be redundant |
This is for users who have ACL rules applied. Even if they are applied a read only ACL rule, they can still see zone details and zone changes while they should only see records and record changes and not anything related to zones. As ACL rules are only for records and even with delete ACL rule applied they can't make any changes to zones. So I thought of hiding those from them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1332
Changes in this pull request: