Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates AppConfig sourced from file and ConfigMap #19

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions charts/backstage/templates/backstage-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ spec:
app.kubernetes.io/component: backstage
spec:
volumes:
{{- if .Values.backstage.extraAppConfig }}
{{- range .Values.backstage.extraAppConfig }}
{{- if .Values.backstage.appConfig.asConfigMap.enabled }}
{{- range .Values.backstage.appConfig.asConfigMap.appConfigAsConfigMap }}
- name: {{ .configMapRef }}
configMap:
name: {{ .configMapRef }}
Expand Down Expand Up @@ -53,8 +53,14 @@ spec:
{{- range .Values.backstage.args }}
- {{ . | quote }}
{{- end }}
{{- if .Values.backstage.extraAppConfig }}
{{- range .Values.backstage.extraAppConfig }}
{{- if .Values.backstage.appConfig.appConfigFile }}
{{- range .Values.backstage.appConfig.appConfigFile }}
- "--config"
- {{ .filename | quote }}
{{- end }}
{{- end }}
{{- if .Values.backstage.appConfig.asConfigMap.enabled }}
{{- range .Values.backstage.appConfig.asConfigMap.appConfigAsConfigMap }}
- "--config"
- {{ .filename | quote }}
{{- end }}
Expand All @@ -68,8 +74,6 @@ spec:
{{- end }}
{{- end }}
env:
- name: APP_CONFIG_backend_listen_port
value: {{ .Values.backstage.containerPorts.backend | quote }}
{{- if .Values.postgresql.enabled }}
- name: POSTGRES_HOST
value: {{ include "backstage.postgresql.host" . }}
Expand All @@ -90,9 +94,9 @@ spec:
- name: backend
containerPort: {{ .Values.backstage.containerPorts.backend }}
protocol: TCP
{{- if .Values.backstage.extraAppConfig }}
{{- if .Values.backstage.appConfig.asConfigMap.enabled }}
volumeMounts:
{{- range .Values.backstage.extraAppConfig }}
{{- range .Values.backstage.appConfig.asConfigMap.appConfigAsConfigMap }}
- name: {{ .configMapRef }}
mountPath: "/app/{{ .filename }}"
subPath: {{ .filename }}
Expand Down
34 changes: 31 additions & 3 deletions charts/backstage/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,38 @@ backstage:
backend: 7007
command: ["node", "packages/backend"]
args: []
extraAppConfig: []

# -- AppConfig that you want your Backstage application to use
appConfig:

# -- AppConfig that you want to supply to your backstage application that is stored
# inside of a ConfigMap
asConfigMap:
enabled: false

# -- The different ConfigMaps to use for your AppConfig
# Example:
# appConfigAsConfigMap:
# - configMapRef: my-dev-app-config
# filename: app-config.dev.yaml
# - configMapRef: my-prod-app-config
# filename: app-config.prod.yaml
appConfigAsConfigMap:
- configMapRef: app-config-production
filename: app-config.production.yaml

# -- AppConfig that you already have inside of the Backstage Image
# Example:
# appConfigFile:
# - filename: app-config.yaml
# - filename: app-config.production.yaml
appConfigFile:
- filename: app-config.yaml
- filename: app-config.production.yaml

extraEnvVars: []
extraEnvVarsSecrets:

extraEnvVarsSecrets: []
## @section Traffic Exposure parameters

## Service parameters
Expand Down Expand Up @@ -216,4 +244,4 @@ postgresql:
replicationPasswordKey: replication-password

# -- PostgreSQL architecture (`standalone` or `replication`)
architecture: standalone
architecture: standalone