-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define extra app config which generates ConfigMap #24
Conversation
Hi @froblesmartin, The chart already has a functionality for passing extra Try it out and let me know if you find any issue. |
Hi @vinzscam ! Thanks a lot for your comment! The problem with the current approach is that the ConfigMap needs to be provided externally from this Helm chart. It is not a big deal, but I think it would be nice to provide both things, generating the ConfigMap in the Helm chart itself, and also allowing us to define the config in the values.yaml file. In the end the idea of the values.yaml file is to be the place where the applications can be configured. Maybe we could generate the ConfigMap from multiple keys which map to the possible configurations of Backstage and then generate the ConfigMap with all that input, but that is a different approach, and would require to keep in sync always the Helm chart values.yaml and template for the ConfigMap with the configurations of Backstage. |
the only concern I have with this approach is that it looks easier to include sensitive variables in the |
Hi @vinzscam ! Sorry for the long delay. I am closing this one on behalf of backstage/charts#23. I changed there the key used to just appConfig, let's keep the conversation there ;) |
As it was been discussed a little bit at #4:
I think it would be nice to give the possibility to define an extra app config file in the values.yaml, which then creates a ConfigMap automatically, mounts it and uses it in the config.
Please, let me know your thoughts, and if there is anything I should improve or change. :)