fixing the nameSuffix parameter

viodotcom · Jul 27, 2023 · 514f52a · 514f52a
1 parent 357ab13
commit 514f52a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/job/job b/src/job/job
@@ -80,7 +80,7 @@ install_resources () {
   fi
 
   kustomize edit set namespace "$namespace"
-  kustomize edit set nameSuffix '-"'$updated_at'"'
+  kustomize edit set namesuffix -- "-$updated_at"
   kustomize edit add annotation --force \
   app.kubernetes.io/instance:"$namespace" \
   app.kubernetes.io/pull_request_number:"$pull_request_number" \
@@ -105,9 +105,7 @@ install_resources () {
   fi
 
   # Apply changes generated by kustomize
-  # https://github.com/kubernetes-sigs/kustomize/issues/641
-  # https://zknill.io/posts/kubernetes-generated-names/
-  kustomize build | sed -e 's/^  name.*$//g' | kubectl create -f - -n "$namespace" --wait=true
+  kustomize build | kubectl apply -f - -n "$namespace" --wait=true
 
   if [ "$verbose" = "false" ]; then
     exit 1;

diff --git a/src/job/resources/base/job.yml b/src/job/resources/base/job.yml
@@ -1,7 +1,7 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  generateName: job-
+  name: job
 spec:
   ttlSecondsAfterFinished: 300
   backoffLimit: 2