Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow custom metadata in script installation window #1637

Closed
TFWol opened this issue Oct 28, 2022 · 7 comments
Closed

[Feature] Allow custom metadata in script installation window #1637

TFWol opened this issue Oct 28, 2022 · 7 comments

Comments

@TFWol
Copy link

TFWol commented Oct 28, 2022

When installing a script for the first time from a website, I would like to edit (rather than only being able to view) prior to it being added.

It's already right there in front of you and saves needing to reopen the script to change it.

@tophf
Copy link
Member

tophf commented Oct 28, 2022

No, I don't think we should encourage editing remotely installed scripts.
@gera2ld?

@TFWol
Copy link
Author

TFWol commented Oct 28, 2022

I typically remove things like icon URLs if they're pointing to a weird website I don't want to touch.
Especially since the connection happens right away whether or not the script is activated.

To alleviate concerns, maybe a setting in Options with it turned off by default?

@tophf
Copy link
Member

tophf commented Oct 28, 2022

I guess we can add an option to ignore script @icon

@gera2ld
Copy link
Member

gera2ld commented Oct 29, 2022

Maybe we can allow changes to custom metadata before confirming installation?

@TFWol
Copy link
Author

TFWol commented Oct 29, 2022

That'd be useful. 99% of the changes deal mostly with those.

@6b6279
Copy link

6b6279 commented Dec 1, 2022

Some kind of option to "fork" a script would be nice too: The userscript get installed, but @downloadURL is empty (so there is no coupling between the local copy of the script and upstream).

@gera2ld gera2ld changed the title [Feature] Allow editing a script in script installation window [Feature] Allow custom metadata in script installation window Jan 8, 2023
@tophf
Copy link
Member

tophf commented Sep 27, 2023

The next version will have an Edit button when installing the script to open the editor in the same tab after installing:

image

@tophf tophf closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants