Unable to install scripts from https://greasyfork.org using incognito mode with Chrome.

[arau0]

What is the problem?

Unable to install scripts from https://greasyfork.org using incognito mode with Chrome.

How to reproduce it?

1. I am not able to install scripts from https://greasyfork.org, when I am using Chrome in incognito mode. If I am using regular, not incognito mode everything is fine.
2. Example https://greasyfork.org/en/scripts/369400-local-youtube-downloader
3. Click on "Install this script".

What is the expected result?

To install scripts from https://greasyfork.org using incognito mode with Chrome

What is the actual result?

Unable to install scripts from https://greasyfork.org using incognito mode with Chrome.

Environment

• Browser: Chrome
• Browser version: Chrome 80
• Violentmonkey version: 2.12.8 rc3
• OS:Windows

[arau0]

@tophf I think that's a bug.
When you click on "Install this script", ViolentMonkey should have the same behavior like you're in incognito mode but using the dashboard there is "plus" icon. Once you pressed the "plus" icon we should have ViolentMonkey open in regular mode and the user just have to confirm the installation.

[tophf]

Just because I disagree doesn't mean I don't understand. I do. My concern is that your expectation violates the basic expectation that anything you do within an incognito web page can't have an effect on the main profile.

To sum it up, my suggestions are:

• a warning that this is unsupported
• a confirmation before installing that the user wants to install the script in their main profile
• show the installation tab but with a big red warning inside

[tophf]

No need to repeat: your point was clear from the get-go. It looks like you miss or intentionally disregard my point though so let's wait for @gera2ld.

[gera2ld]

I think it's better to allow installation from an incognito window because otherwise it's hard to use.

In my opinion, an extension is something beyonds the normal and incognito modes, more like a background service that provides some common UI, so there is no need to distinguish them.

Some people care a lot about privacy and may expect changes from incognito mode being ignored, we can prevent them from further actions by adding an explicit notice before the first action performs, or just pin a warning at the top like the following image. I guess it could also be added to the privacy policy.

BTW, AdBlock Plus also applies actions in incognito mode to the normal mode, in other words they don't handle incognito mode differently.

@tophf Do you agree on this?

[tophf]

Yes, the warning in the popup looks cool. The same will be shown in the installation page when it's opened from a click inside an incognito tab, I guess.

[tophf]

On the other hand, maybe the red background should be used only in the installation page, and a standard background in the popup...

[tophf]

So to clarify, there was indeed a bug (openerTabId cannot be used across different windows) and a UI enhancement to make sure the users don't shoot themselves in the foot.

See #963 for screenshots.

[arau0]

@tophf Finally :) Thank you for the bug confirmation.

@gera2ld I agree with you to "allow installation from an incognito window because otherwise it's hard to use".

I already said "If you're in incognito mode, visit https://greasyfork.org and click on "Install this script", ViolentMonkey should open the script in regular-normal tab, not in incognito".

The user is giving appropriate permissions ViolentMonkey to run in incognito tabs.
If the user don't want any changes to be made by ViolentMonkey will not give this permisions.
That's why I still don't see a point to pin a warning at the top of the dashboard in incognito tab.

BTW, @gera2ld I am not sure if @gorhill is considiring that in future but I don't see such as behavior in uBlockOrigin.

In the end of the day that's my opninion and I see how are considiring it. Respect to your effort and time.

[gera2ld]

@arau0 Allowing it to run in incognito tabs does not mean to expect the changes to persist.

People might expect to have a brand new profile for Violentmonkey in incognito mode, maybe for experimental purpose, or to use some NSFW userscripts and expect them to vanish after closing the window.

Anyway we don't expect that so we try to avoid confusing users in such a way.

[tophf]

The warning will be displayed at the bottom in the incognito popup, see #963.

[arau0]

@gera2ld I see your point and understand it.