Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored and fixed jobs without properties #3

Merged
merged 1 commit into from
May 31, 2019
Merged

Refactored and fixed jobs without properties #3

merged 1 commit into from
May 31, 2019

Conversation

f0rmiga
Copy link
Collaborator

@f0rmiga f0rmiga commented May 30, 2019

  • Added Go modules support.
  • Pulled the ruby script into its own file.
  • Generated the embedded ruby script with go generate.
  • Added test when a job spec doesn't have any properties.

@f0rmiga f0rmiga requested a review from viovanov May 30, 2019 23:06
@viovanov viovanov merged commit 39f4ed6 into master May 31, 2019
@viovanov viovanov deleted the f0rmiga/refactor-and-fix-no-properties branch May 31, 2019 00:28
@f0rmiga f0rmiga mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viovanov viovanov viovanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f0rmiga @viovanov