Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java bindings for Scala 2.13 #317

Merged
merged 6 commits into from
Dec 14, 2020
Merged

Upgrade Java bindings for Scala 2.13 #317

merged 6 commits into from
Dec 14, 2020

Conversation

fpoli
Copy link
Member

@fpoli fpoli commented Dec 11, 2020

@Aurel300 This should fix the build.

Closes #281.

@Aurel300
Copy link
Member

I think Fábio mentioned some segfaults with Java 11 and recommended OpenJDK 15?

@fpoli
Copy link
Member Author

fpoli commented Dec 11, 2020

I think Fábio mentioned some segfaults with Java 11 and recommended OpenJDK 15?

Yes. I'm running with 11 just to see the error message at least once, to recognize it in future debugging sessions :)

@fpoli
Copy link
Member Author

fpoli commented Dec 11, 2020

Also, I still have to find a nice way of installing OpenJDK 15 on Ubuntu 18.04 (the Github runner) and I have to find some time to upgrade from my Ubuntu 16.04 😞

@fpoli fpoli self-assigned this Dec 14, 2020
@fpoli fpoli force-pushed the upgrade-scala-2.13 branch 2 times, most recently from 90e023c to 7a12dfe Compare December 14, 2020 09:55
@fpoli fpoli merged commit bb97608 into master Dec 14, 2020
@fpoli fpoli deleted the upgrade-scala-2.13 branch December 14, 2020 12:18
@Aurel300
Copy link
Member

FWIW I needed to do a clean build (./x.py clean before ./x.py build --all), because I was getting errors about -ljvm not resolving.

Also, I just got this message when running a test:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/silicon.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/ch.qos.logback.logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]

Seems to just be informative but maybe something is wrong with how silicon.jar is packaged?

@vakaras
Copy link
Contributor

vakaras commented Dec 15, 2020

Also, I just got this message when running a test:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/silicon.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/ch.qos.logback.logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]

Seems to just be informative but maybe something is wrong with how silicon.jar is packaged?

I think @aterga fixed this last time.

cc @fabiopakk

@fpoli
Copy link
Member Author

fpoli commented Dec 15, 2020

FWIW I needed to do a clean build (./x.py clean before ./x.py build --all), because I was getting errors about -ljvm not resolving.

Also, I just got this message when running a test:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/silicon.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/r/prusti-dev/viper_tools/backends/ch.qos.logback.logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]

Seems to just be informative but maybe something is wrong with how silicon.jar is packaged?

Indeed, it seems that there are duplicate classes. I already opened an issue at viperproject/viperserver#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test mut-borrows-binary-search.rs
3 participants