Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFM22 examples #901

Merged
merged 12 commits into from
May 27, 2022
Merged

NFM22 examples #901

merged 12 commits into from
May 27, 2022

Conversation

Aurel300
Copy link
Member

@Aurel300 Aurel300 commented Mar 13, 2022 •
edited by JonasAlaif
Loading

This is to allow linking the examples online from the paper. PRs to be done before the deadline:

@JonasAlaif
Copy link
Contributor

JonasAlaif commented May 21, 2022 •
edited
Loading

Commits ab9d11b, 7676e26 and 89ab21f should not be necessary imo, but I guess these issues won't be fixed by Thursday @Aurel300? In particular the #917 issue is the most obnoxious

@JonasAlaif JonasAlaif mentioned this pull request May 22, 2022
Draft
@JonasAlaif
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request May 24, 2022
@bors @Aurel300 @JonasAlaif
Merge #901
a1642b8 
901: NFM22 examples r=JonasAlaif a=Aurel300

This is to allow linking the examples online from the paper. PRs to be done before the deadline:

- [x] #686 
- [x] #882 
- [x] #887 
- [x] #899 


Co-authored-by: Aurel Bílý <aurel.bily@gmail.com>
Co-authored-by: Jonas <jonas.fiala.cardiff@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 24, 2022

Build failed:

@JonasAlaif
Copy link
Contributor

@Aurel300 how can we merge this, the CI fails since type invariants aren't enabled by default

@Aurel300 Aurel300 marked this pull request as ready for review May 27, 2022 11:37
@Aurel300
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 27, 2022

Build succeeded:

@bors bors bot merged commit 5a3f296 into viperproject:master May 27, 2022
@Aurel300 Aurel300 deleted the nfm22-examples branch May 27, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aurel300 @JonasAlaif