Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sure plugins get a proper config object #186

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Making sure plugins get a proper config object #186

merged 3 commits into from
Dec 14, 2023

Conversation

marcoeilers
Copy link
Contributor

… and forwarding whitelisted options to ASTProvider.
This is an attempt to fix #165 and #184.

ArquintL
ArquintL approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@ArquintL ArquintL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but due to an absence of code comments, I'm wondering about the design decisions

src/main/scala/viper/server/core/VerificationWorker.scala Show resolved Hide resolved
src/main/scala/viper/server/utility/AstGenerator.scala Show resolved Hide resolved
@ArquintL ArquintL added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit ec92d51 Dec 14, 2023
13 checks passed
@marcoeilers marcoeilers deleted the meilers_plugins_config branch December 14, 2023 15:05
@marcoeilers marcoeilers mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArquintL ArquintL ArquintL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin input with --plugin in customArguments does not work
2 participants
@marcoeilers @ArquintL