Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethnode: geth changed node input parsing, breaking admin_addTrustedPeer #65

Closed
shazow opened this issue Jul 15, 2019 · 0 comments · Fixed by #67
Closed

ethnode: geth changed node input parsing, breaking admin_addTrustedPeer #65

shazow opened this issue Jul 15, 2019 · 0 comments · Fixed by #67
Assignees
@shazow
Labels
Bug Something isn't working Urgent Needs to be resolved as soon as possible

Comments

@shazow
Copy link
Member

shazow commented Jul 15, 2019

Looks like geth added new checks to the way node inputs get parsed: ethereum/go-ethereum#19663

Some of our users are getting:

invalid enode: missing 'enr:' prefix for base64-encoded record

We were sending passing in just the Enode ID, but looks like it requires an enode:// prefix to always be present now.
@shazow shazow added Bug Something isn't working Urgent Needs to be resolved as soon as possible labels Jul 15, 2019
@shazow shazow self-assigned this Jul 15, 2019
@shazow shazow mentioned this issue Jul 15, 2019
Closed
shazow added a commit that referenced this issue Jul 15, 2019
@shazow
ethnode: Prefix enode:// on nodeID for geth
2e2c8ef 
Fixes #65
shazow added a commit that referenced this issue Jul 15, 2019
@shazow
ethnode: Prefix enode:// on nodeID for geth
516d099 
Fixes #65
@shazow shazow mentioned this issue Jul 15, 2019
Merged
shazow added a commit that referenced this issue Jul 15, 2019
@shazow
ethnode: Prefix enode:// on nodeID for geth
c821f41 
Fixes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shazow shazow

Labels
Bug Something isn't working Urgent Needs to be resolved as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ethnode: Fix new geth nodeID format check vipnode/vipnode
1 participant
@shazow