Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: Use fully qualified enode strings instead of nodeIDs for AddTrustedNode #90

Open
shazow opened this issue Dec 4, 2019 · 1 comment
Open

agent: Use fully qualified enode strings instead of nodeIDs for AddTrustedNode #90

shazow opened this issue Dec 4, 2019 · 1 comment
Assignees
@shazow
Labels
Soon Candidate for the next major release

Comments

@shazow
Copy link
Member

shazow commented Dec 4, 2019 •
edited
Loading

ethnode has a hacky workaround to patch nodeIDs to enode strings with null addresses (both geth and parity), but would be better if we just pass in the correct thing instead.
@shazow shazow added the Soon Candidate for the next major release label Dec 4, 2019
@shazow shazow self-assigned this Dec 4, 2019
@shazow shazow mentioned this issue Dec 4, 2019
Merged
@shazow
Copy link
Member Author

shazow commented Dec 6, 2019

This is proving to be a deeper refactor than I hoped, but probably worth doing eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shazow shazow

Labels
Soon Candidate for the next major release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shazow