Skip to content

Commit

Permalink
Remove irrelevant message and allow custom messages
Browse files Browse the repository at this point in the history
  • Loading branch information
riceissa committed Aug 13, 2017
1 parent dc13dcd commit 833c0ae
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
4 changes: 0 additions & 4 deletions TODO.md
@@ -1,9 +1,5 @@
Minor wrap-up

* In function Issa created, customized header message that can provide
custom notes at top of table. This can include warnings on data
meaning and interpretation.

* Add tables such as cause area X influencer, cause area X country, cause area X disclosures

* There are still a bunch of `PHP Notice: Undefined offset:` warnings when
Expand Down
3 changes: 2 additions & 1 deletion access-portal/backend/yearlyDisclosures.inc
Expand Up @@ -300,7 +300,8 @@ EOD;
$causeAreaFilterString,
$donor,
$generateGraphCmdBase,
$imagesPath
$imagesPath,
""
);
}

Expand Down
13 changes: 9 additions & 4 deletions access-portal/backend/yearlyGroupings.inc
Expand Up @@ -205,7 +205,8 @@ EOD;
$causeAreaFilterString,
$donor,
$generateGraphCmdBase,
$imagesPath
$imagesPath,
""
);

}
Expand All @@ -219,7 +220,8 @@ function printYearlyGroupedHtmlTable(
$causeAreaFilterString,
$donor,
$generateGraphCmdBase,
$imagesPath
$imagesPath,
$customHtmlMessage
) {

$donorString = $donor ? "donor" : "";
Expand All @@ -233,8 +235,11 @@ function printYearlyGroupedHtmlTable(
. "you will get a tooltip with the number of donees and the number of "
. "donations.</p>\n";

print "<p>Note: Cause area classification used here may not match that "
."used by donor for all cases.</p>\n";
print "<p>For the meaning of “classified” and “unclassified”, see the "
. '<a href="https://github.com/vipulnaik/donations/blob/master/classified-and-unclassified.md">'
. "page clarifying this</a>.</p>\n";

print $customHtmlMessage;

print '<table id="myTable' . ucfirst($donorString)
. 'DonationAmountsBy' . ucfirst($groupName) . 'AndYear" '
Expand Down

0 comments on commit 833c0ae

Please sign in to comment.