Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Badly formatted email" error on valid mails #63

Closed
ChristophHaag opened this issue Nov 7, 2020 · 1 comment
Closed

"Badly formatted email" error on valid mails #63

ChristophHaag opened this issue Nov 7, 2020 · 1 comment
Labels
bug Something isn't working
Projects
Iamus 2.4

Comments

@ChristophHaag
Copy link

Don't validate email addresses with a simple regex https://github.com/kasenvr/Iamus/blob/729cdd156c95d514751a7663bafd6b584c725d49/src/Entities/AccountEntity.ts#L143

Validate email by actually sending an email. See also #47.

https://www.youtube.com/watch?v=xxX81WmXjPg
@Misterblue
Copy link
Collaborator

Misterblue commented Nov 7, 2020 •
edited

Which way should Vircadia go? I see three possible changes:

  1. Completely RFC compliant regex (it's long -- I checked)
  2. not testing at all (it's an email and if it doesn't work, that's the user's and admin's problem)
  3. make the regex a server configuration parameter so a grid can be as picky as it wishes

Going for 2) and eventually having #47 operational (verify email handshake) is the direction I'm leaning.
What is the opinion of the crowd?

@Misterblue Misterblue added the bug Something isn't working label Nov 7, 2020
@Misterblue Misterblue added this to To Do in Iamus 2.4 via automation Nov 7, 2020
Iamus 2.4 automation moved this from To Do to Done Nov 7, 2020
Loudened pushed a commit to Loudened/overte-metaverse that referenced this issue Jul 23, 2023
@Misterblue
Tone down the AccountEntity.email format validation to require one AT…
6d96429 
… sign

    An RFC complient email address can be very complex so rely on later
    email verification handshake to really checkout that email is a good format.
Closes vircadia#63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Iamus 2.4
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Misterblue @ChristophHaag