Update build docs #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The request /api/v1/account/:accountId accepts either the accountId or the account username for the ":accountId". See 'src/route-tools/middleware.ts::accountFromParams()' which looks up by username and, if not found, looks up by accountId. Also note that the username is URI encoded so special characters and such are processed correctly. |
|
This PR includes the commits from PR#68 which is confusing. |
|
Heh, yeah, once 68 gets merged then this will clear up. :) |
|
Is this PR still necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of PR #68
One problem that I am probably going to need to solve in Iamus with this PR is to add an API call to retrieve a user by username instead of their account ID as it might often be the case that you know their username but not their accountID. The only way for me to retrieve data on a specific user is to pull the entire userbase list then run through each one looking for a match which might be a performance/programming issue depending on what was looking to pull up this data.
So it might be good to have the database perform this check since it's probably far more performant and also has less back and forth involved.