Explore App: Use the placename instead of address (ip:port). #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple change that is using the placename instead of the "address" feild from the place api to build the url to connect. For those where the placename = the domain name, Interface will be able to resolve path correctly. using the address, this makes interface using 100% of the time the ip:/port information.
digisomni
added
CR Approved
digisomni
approved these changes
Dec 16, 2021
|
Works! |
digisomni
added
QA Approved
digisomni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change that is using the placename instead of the "address" feild from the place api to build the url to connect.
For those where the placename = the domain name, Interface will be able to resolve path correctly.
using the address, this makes interface using 100% of the time the ip:/port information.