Fix MultiHash issues added in PR #1468. #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digisomni
added
needs CR (code review)
needs testing (QA)
|
Test model and its blendshapes in general to confirm PR is working as expected: https://github.com/vircadia/vircadia/files/7770367/steve_hocktail.tar.gz |
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
ctrlaltdavid
approved these changes
Jan 14, 2022
ctrlaltdavid
added
CR Approved
digisomni
changed the title
digisomni
added
QA Approved
digisomni
approved these changes
Jan 15, 2022
|
Tested at community meeting, works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Tested with the model included in that issue, seems to work fine now.