Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled vcpkg bootstrapping in PR and master builds. #1606

Merged
merged 2 commits into from Feb 21, 2022

Conversation

namark
Copy link
Contributor

@namark namark commented Feb 21, 2022

to see if it fixed a specific build issue on windows.

to see if it fixed a specific build issue on windows.
@namark namark added do not merge do not merge due to issues or pending updates rebuild rebuild through the GithubActions labels Feb 21, 2022
and removed the unclear comments, since macOS builds seem to be working
fine now.
@namark namark removed the do not merge do not merge due to issues or pending updates label Feb 21, 2022
@digisomni digisomni changed the title Enabled vcpkg bootstrapping in PR builds Enabled vcpkg bootstrapping in PR builds. Feb 21, 2022
@digisomni
Copy link
Member

The full macOS build does run, didn't test extensively but it seems to work.

@digisomni digisomni added this to In progress in 2022.1.1 Selene Release via automation Feb 21, 2022
@digisomni digisomni added this to the 2022.1.1 Selene Release milestone Feb 21, 2022
2022.1.1 Selene Release automation moved this from In progress to Reviewer approved Feb 21, 2022
@digisomni digisomni changed the title Enabled vcpkg bootstrapping in PR builds. Enabled vcpkg bootstrapping in PR and master builds. Feb 21, 2022
@digisomni digisomni merged commit f25da82 into vircadia:master Feb 21, 2022
2022.1.1 Selene Release automation moved this from Reviewer approved to Done Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebuild rebuild through the GithubActions
Development

Successfully merging this pull request may close these issues.

None yet

3 participants