Fix new Zones appearing as parent of a ghost child #874
Conversation
Upgrading
This excludes the local and avatar entities from what is returns by Entities.getChildrenIDs to avoid the selection tools of the Zone entities to be considered as Children of it. This was necessary for the display of the hierarchy status, but also for the "Add Children to Selection".
This excludes the local and avatar entities from what is returns by Entities.getChildrenIDs to avoid the selection tools of the Zone entities to be considered as Children of it. This was necessary for the display of the hierarchy status, but also for the "Add Children to Selection".
HifiExperiments
added
allow-build-upload
|
The following links are available: build (windows-latest, full) build (ubuntu-18.04, full)
|
ctrlaltdavid
added
CR Approved
|
According to QA it worked as expected: I created the zone entity and it doesn't show any children under it on the icon. Though, I didn't test any parenting as I was unsure what causes what in that respect. |
two-one-five
added
QA Approved
|
@AleziaKurdis May I suggest making a tickbox to allow avatar/local entities to show up as children? (can be off by default which would equate to the functionality you are suggesting), Means that people who are creating complex avatars for example. |
|
Hmm... Can we use the create application to edit avatar entities? Because we can't for "Local" entities. They are not visible in the list and can't be selected. |
|
We are able to adjust wearables with the Create App as far as I know. |
|
We will put this PR on HOLD. |
two-one-five
added
do not merge
Excluding EntityShapeVisualizer from Children list Now a name is given to the EntityShape of the EntityShapeVisualizer (used to display the zone) so we can now exclude them from the children list when it's time to figure if there are children for an entity. (This is a better approach than excluding al the local entities) The name has been used because it gives better results than trying to use the id map that arrive always too late. The name is unique for a session, it includes a UUID.
Excluding EntityShapeVisualizer from Children list Now a name is given to the EntityShape of the EntityShapeVisualizer (used to display the zone) so we can now exclude them from the children list when it's time to figure if there are children for an entity. (This is a better approach than excluding al the local entities) The name has been used because it gives better results than trying to use the id map that arrive always too late. The name is unique for a session, it includes a UUID.
|
Finally, I change the approach. So this will continue to work for all types of entities. (domain, local, avatar) I still don't think it will be viable to have the local entities visible in the create Application If we do this, I suggest that we implement a property to have specific local entities to never be returned by the findEntities### methods, getChildrens, and certainly some others. |
|
You can now remove the "Do not Merge" flag and gives this to QA. |
two-one-five
added
needs CR (code review)
needs testing (QA)
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) |
Minor code adjustments
ctrlaltdavid
added
CR Approved
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) |
|
Seems to be working as expected now. |
two-one-five
added
QA Approved
ctrlaltdavid
changed the title
Fix for Issue #869
This excludes the local and avatar entities from what is returns by Entities.getChildrenIDs
to avoid the selection tools of the Zone entities to be considered as Children of it.
This was necessary for the display of the hierarchy status, but also for the "Add Children to Selection".
For the QA:
1- Open the "Create" Application
2- Make sure to have the "Hierarchy" column displayed in the entity list.
3- Create a new Zone entity
Before this fix:
The new zone entity was displayed as being a Top Parent. (because there was a local entity parented to it. (to display the grid box)
In In-world view, the bounding box was also indicating that it was a Top Parent (it was displayed in Orange instead of light gray)
If you selected that new zone, and do "Selection... > Add Children to Selection", the bounding box turned light gray as a multiple selection. If you were keeping CTRL pressed and deselect the zone only, then you could see the invisible local entity selected with a bounding box in cyan (as a child).
After this fix:
No more trace of any children, since local entities are now ignored when we get the list of the children.
So new zones are no more displayed as a Parent of a child that we didn't expect. And the "Selection... > Add Children to Selection" won't consider this false child too.