Fix skipping deleting an instanced trait when reading BulkAvatarTraits message.

src/domain/avatars/AvatarTraits.ts

@@ -91,6 +91,8 @@ type AvatarTraitsValues = {
  *  @property {AvatarTraits.TraitType} TotalTraitTypes=4 - The number of trait types. <em>Read-only.</em>
  *  @property {AvatarTraits.TraitType} NUM_SIMPLE_TRAITS=2 - The number of simple traits. <em>Read-only.</em>
  *  @property {number} DEFAULT_TRAIT_VERSION=0 - The default trait version sequence number. <em>Read-only.</em>
+ *  @property {number} DELETED_TRAIT_SIZE=-1 - The nominal trait binary size for deleting an instanced trait.
+ *      <em>Read-only.</em>
  */
 const AvatarTraits = new class {
     // C++  namespace AvatarTraits
@@ -150,6 +152,7 @@ const AvatarTraits = new class {
     readonly NUM_SIMPLE_TRAITS = TraitType.FirstInstancedTrait;
 
     readonly DEFAULT_TRAIT_VERSION = 0;
+    readonly DELETED_TRAIT_SIZE = -1;
 
 
     /*@devdoc

src/domain/networking/packets/BulkAvatarTraits.ts

@@ -102,7 +102,9 @@ const BulkAvatarTraits = new class {
                         this.#_haveWarnedComplexTraits = true;
                     }
 
-                    dataPosition += traitBinarySize;
+                    if (traitBinarySize > AvatarTraits.DELETED_TRAIT_SIZE) {
+                        dataPosition += traitBinarySize;
+                    }
                 }
 
                 // Read the next trait type, which is Null Trait if there are no more traits for this avatar.

tests/domain/avatars/AvatarTraits.unit.test.js

@@ -19,6 +19,7 @@ describe("AvatarTraits - unit tests", () => {
         expect(AvatarTraits.SkeletonModelURL).toBe(0);
         expect(AvatarTraits.TotalTraitTypes).toBe(AvatarTraits.Grab + 1);
         expect(AvatarTraits.DEFAULT_TRAIT_VERSION).toBe(0);
+        expect(AvatarTraits.DELETED_TRAIT_SIZE).toBe(-1);
     });
 
     test("Can check whether a trait is a simple trait type", () => {