Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update overlay manager. #26

Merged
merged 5 commits into from Oct 6, 2021
Merged

Update overlay manager. #26

merged 5 commits into from Oct 6, 2021

Conversation

Madders
Copy link
Contributor

@Madders Madders commented Oct 4, 2021

Fixes to the overlay manager whereby it wasn't working to move and resize windows.

Have also implemented the minimize and maximize functions.

digisomni
digisomni approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login dialog box has no way to close (was not introduced with this PR), also maybe it should be one of the overlays... dunno yet. Either way that can be fixed in another set of revisions.

Web Part 1: Interface + SDK - May through October 2021 automation moved this from In progress to Reviewer approved Oct 6, 2021
@digisomni digisomni added bugfix CR Approved At least one code reviewer has approved the PR enhancement New feature or request QA Approved Has been tested successfully labels Oct 6, 2021
@digisomni digisomni merged commit c0f6a9e into vircadia:master Oct 6, 2021
Web Part 1: Interface + SDK - May through October 2021 automation moved this from Reviewer approved to Done Oct 6, 2021
@digisomni digisomni changed the title Overlay manager fixes Update overlay manager. Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR enhancement New feature or request QA Approved Has been tested successfully
Projects
No open projects
Web Part 1: Interface + SDK - May thr...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Madders @digisomni