Replace the deprecated QVector::fromStdVector and QVector::toStdVector(). #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, full) build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
HifiExperiments
approved these changes
Nov 27, 2021
| output.edit1() = hfmModelIn->originalURL; | ||
| output.edit2() = hfmModelIn->meshIndicesToModelNames; | ||
| auto& blendshapesPerMesh = output.edit3(); | ||
| blendshapesPerMesh.reserve(hfmModelIn->meshes.size()); | ||
| for (int i = 0; i < hfmModelIn->meshes.size(); i++) { | ||
| blendshapesPerMesh.push_back(hfmModelIn->meshes[i].blendshapes.toStdVector()); | ||
| blendshapesPerMesh.push_back(std::vector<hfm::Blendshape>(hfmModelIn->meshes[i].blendshapes.begin(), hfmModelIn->meshes[i].blendshapes.end())); |
There was a problem hiding this comment.
could save a reference to hfmModelIn->meshes[i] just above to avoid indexing twice
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, client) build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
digisomni
added
CR Approved
digisomni
changed the title
|
Needs an update. |
daleglass
force-pushed
the
qt5-fix-vector
branch
from
1a6020d
to
7f41f1a
Compare
|
The following links are available:
build (macOS-10.15, full) build (macOS-10.15, client) build (windows-latest, full) |
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, full) build (windows-latest, full) |
JulianGro
added
rebuild
|
The following links are available:
build (windows-latest, full) |
daleglass
added
rebuild
digisomni
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Appears to work fine. I don't think we could ever bake glTF models, right?
When I would uncheck the bake box for an FBX model, it would stay on pending... checking it again to use baked would work though. Unsure if that was an existing / related issue or not.
digisomni
added
QA Approved
daleglass
force-pushed
the
qt5-fix-vector
branch
from
7f41f1a
to
8d8d43e
Compare
digisomni
added
rebuild
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make no functional difference, but get rid of ~20 warnings.
This is based on top of PR #1468