console: When resizing window to VM, unmaximize only if maximized #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under a KDE Wayland session, unmaximizing a normal window, then resizing it right away results in nothing happening. Check if the console window is maximized first.
|
Seems like it's a Gtk quirk as it reproduces on a minimal example too, filed an issue on Gtk as well. |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 79 79
Lines 12401 12401
=======================================
Hits 12391 12391
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under a KDE Wayland session, unmaximizing a normal window, then resizing it right away results in nothing happening. Check if the console window is maximized first.
As for why this is the case, I don't know. If the window is maximized when trying to resize to VM, everything works. Maybe it's some sort of a race condition in Gtk that needs further investigation, but for now, this at least fixes virt-manager.