Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1401420: xen supports only uuid/hostname as hypervisor_id #78

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

jirihnidek
Copy link
Collaborator

* Bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=1401420
* Manual pages already contains this information:
  "hwuuid is applicable to esx and rhevm only."
* This bug is caused probably by copy pasting code from esx/rhevm.
@jirihnidek
Copy link
Collaborator Author

@cnsnyder
Copy link
Member

@jirihnidek I wonder if there is something else that could be used for the hwuuid, something else that would be more unique. I would also be curious to know if the same issue exists already for esx and / or rhevm?

@cnsnyder
Copy link
Member

@jirihnidek Looking at the definition of hwuuid for esx, it seems xen and esx are using quite different values for hwuuid. So I think removing it in the meantime is ok. We might want to consider finding an alternative in the future though.

@cnsnyder cnsnyder merged commit 657dc25 into master Jun 19, 2017
@jirihnidek
Copy link
Collaborator Author

@cnsnyder I doubt we can find anything, where we can guarantee uniqueness (Xen, libvirtd). In theory it could be hypervisor MAC address of physical network interface, but in practice neither MAC address it is not 100% unique. When I look at json report from xen system, I don't see any MAC address there though.

I think it is OK to allow hwuuid only for esx and rhevm, because these systems are masters of hwuuid uniqueness. Thus this uniqueness can be guaranteed.

@jirihnidek jirihnidek deleted the jhnidek/1401420 branch June 20, 2017 20:36
@vritant
Copy link
Contributor

vritant commented Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants