Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pallet Referenda] Confirmation Candle #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pandres95
Copy link
Member

@pandres95 pandres95 commented Mar 22, 2024

This change resolves the Referenda Confirmation by Candle Auction RFC

@pandres95 pandres95 force-pushed the pandres95--confirmation-candle branch from acf74ed to 3a275ea Compare March 26, 2024 21:07
@pandres95 pandres95 force-pushed the pandres95--confirmation-candle branch from 3a275ea to 6c059c3 Compare March 26, 2024 21:15
@pandres95 pandres95 force-pushed the pandres95--confirmation-candle branch from 6c059c3 to 37798c4 Compare March 26, 2024 21:18
Copy link
Member

@olanod olanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I think we need some minor adjustments but looks good overall :)

substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/referenda/src/lib.rs Outdated Show resolved Hide resolved
@pandres95 pandres95 force-pushed the pandres95--confirmation-candle branch 6 times, most recently from 09f92e5 to ca43dbc Compare April 2, 2024 15:19
@pandres95 pandres95 force-pushed the pandres95--confirmation-candle branch from ca43dbc to 8c339c9 Compare April 2, 2024 15:23
@pandres95 pandres95 requested a review from olanod April 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants