Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary items in dynamic property dropdown truncated to 20 #2702

Closed
j-mok opened this issue Oct 3, 2023 · 3 comments
Closed

Dictionary items in dynamic property dropdown truncated to 20 #2702

j-mok opened this issue Oct 3, 2023 · 3 comments

Comments

@j-mok
Copy link
Contributor

j-mok commented Oct 3, 2023

Description
In the UI, the dropdown list with dynamic property dictionary items is never longer than 20 items.

Current implementation uses the default SearchCriteriaBase.Take value:

$scope.getDictionaryValues = function (property, callback) {
dictionaryItemsApi.query({ id: property.objectType, propertyId: property.id }, callback);
}

[ApiExplorerSettings(IgnoreApi = true)]
[Obsolete("use POST api/platform/dynamic/dictionaryitems/search instead")]
[HttpGet]
[Route("types/{typeName}/properties/{propertyId}/dictionaryitems")]
public async Task<ActionResult<DynamicPropertyDictionaryItem[]>> GetDictionaryItems([FromRoute] string typeName, [FromRoute] string propertyId)
{
var result = await _dynamicPropertyDictionaryItemsSearchService.SearchDictionaryItemsAsync(new DynamicPropertyDictionaryItemSearchCriteria { PropertyId = propertyId, ObjectType = typeName });
return Ok(result.Results);
}

Steps to reproduce

  • Create a dynamic property with >20 items
  • When editing the property for an object you can see only 20 items in the dropdown list

Expected behavior
Any of these:

  • All items are displayed
  • The limit is raised to significantly higher number (100, 1000?)
  • The limit is configurable
  • The dropdown is replaced with some sort of advanced selector (possibly with paging) for high item numbers to avoid an unpractically long list drop (still the threshold should be higher than 20)

Version info:

  • Browser version: any
  • Platform version: current dev, 3.421

Additional context (optional)
Add any other context about the problem here.

@mvktsk
Copy link
Contributor

mvktsk commented Oct 3, 2023

Task https://virtocommerce.atlassian.net/browse/VP-8452 has been created

@OlegoO
Copy link
Contributor

OlegoO commented Oct 6, 2023

Fixed in #2706

@Dan-BV Dan-BV closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants