use symfony filesystem->exists instead of 'find' #27
Conversation
| $process = $this->getProcess("find ~/ -name \".pearrc\""); | ||
| $process->run(); | ||
| if ($process->getOutput()) { | ||
| $fs = $this->getFilesystem(); |
There was a problem hiding this comment.
Not sure the benefits of having define the $fs variable here. You're not reusing and having it in the if won't make the size of the statement go outside of the min-line of PSR2.
Other than that, this is exactly what we were talking about.
|
@jakerella Do you have any error messages/logs and maybe the output of "ls -la ~" when that related error occurred? I'd really like to have a look at them. |
elexx
changed the title
|
I've tried but was not able to reproduce an exception. Mainly I modified the permissions of .pearrc and created a new environment using the code from this pull request, which printed the warning every time (because .pearrc exists) but created the environment successfully. If you come across that other exception, feel free to @mention me and I'll take at look at it. |
use symfony filesystem->exists instead of 'find'
fixes #25
Feedback is welcome!