Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挌 Fix building python clients #17

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

dmihalcik-virtru
Copy link
Contributor

Proposed Changes

Checklist

Testing Instructions

- Invalid trove classifier, BSD 3 Clause. See list here: https://pypi.org/classifiers/
- Since this is ambiguous, this adds a license_expression per https://peps.python.org/pep-0639
@dmihalcik-virtru dmihalcik-virtru merged commit 1f7f626 into main Aug 16, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/fix-build-with-hatchling branch August 16, 2022 15:31
@bleggett
Copy link
Contributor

The python is generated code, but not linted as part of CI, correct - that can be added.

Relatedly, I think I dorked up the CI gates - all previous PRs have a validated passing CI gate but this one skipped - investigating.

@bleggett
Copy link
Contributor

bleggett commented Aug 16, 2022

Fixed the CI gate - tho you can see for each PR if ci_gate passed, I think the repo settings weren't explicitly requiring ci_gate to pass before allowing merge - that is fixed.

Build fix here: #18

Thx guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants