feat: delegated identity support #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e979e99.
T ysalazar/mi for image pull
…salazar/azure-aci into t-ysalazar/mi-for-image-pull
T ysalazar/mi for image pull
dynamic values in mi-image-pull podspecs
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 42.92% 43.30% +0.37%
==========================================
Files 35 35
Lines 3471 3621 +150
==========================================
+ Hits 1490 1568 +78
- Misses 1800 1866 +66
- Partials 181 187 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
helayoty
changed the title
helayoty
reviewed
Mar 27, 2023
| @@ -69,3 +68,69 @@ func (c *Client) ListContainerGroups(ctx context.Context, resourceGroup string) | |||
|
|
|||
| return &list, nil | |||
| } | |||
|
|
|||
| func (c *Client) ListAKSClusters(ctx context.Context, resourceGroup string) (*AKSClusterListResult, error) { | |||
There was a problem hiding this comment.
After migrating to use nodeUtils, you should find an easier way to get k8s configs using
k8sClient, err := nodeutil.ClientsetFromEnv(kubeConfigPath)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegated Identity support along with MI for image pull
Request sent to ACI for pod with delegated identity
