Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a validation init container #388

Merged
merged 9 commits into from
Jan 19, 2023
Merged

feat: Add a validation init container #388

merged 9 commits into from
Jan 19, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Dec 13, 2022 •
edited
Loading

  • Create Dockerfile and pkg folder for init container
  • Add support for init container in helm chart, deployments for e2e tests
  • Add support for init container in pipelines

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

@helayoty helayoty added kind/enhancement New feature or request kind/feature labels Dec 13, 2022
@helayoty helayoty temporarily deployed to test December 13, 2022 20:44 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 20:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 20:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 20:53 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 20:53 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 20:54 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #388 (45aa516) into master (0c76852) will increase coverage by 0.00%.
The diff coverage is 47.16%.

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   42.91%   42.92%           
=======================================
  Files          50       50           
  Lines        5735     5764   +29     
=======================================
+ Hits         2461     2474   +13     
- Misses       3017     3033   +16     
  Partials      257      257
Impacted Files Coverage Δ
pkg/network/aci_network.go 24.41% <0.00%> (-2.12%) ⬇️
pkg/provider/config.go 68.29% <0.00%> (ø)
pkg/provider/aci.go 33.93% <57.14%> (+0.04%) ⬆️
pkg/auth/auth.go 69.37% <91.30%> (+2.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test December 13, 2022 21:04 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:08 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:09 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:09 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:10 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:19 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:21 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:22 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:50 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:50 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:52 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 13, 2022 21:53 — with GitHub Actions Inactive
@helayoty
Add more logs
92b6fcd 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty
Add tracing and logs
897074b 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty
go vet/fmt
8187a8a 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty
add retry for setup
d02e79f 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty
Remove provider obj and use wait.Until
cbb2e27 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 18, 2023 17:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 17:04 — with GitHub Actions Inactive
@helayoty
Implement events for the init container
14f8791 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 18, 2023 20:49 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 20:49 — with GitHub Actions Inactive
Fei-Guo
Fei-Guo reviewed Jan 18, 2023
View reviewed changes
cmd/init-container/main.go Outdated Show resolved Hide resolved
cmd/init-container/main.go Show resolved Hide resolved
pkg/util/events.go Outdated Show resolved Hide resolved
pkg/network/aci_network.go Outdated Show resolved Hide resolved
@helayoty
code review comments
45aa516 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 18, 2023 22:05 — with GitHub Actions Inactive
@helayoty helayoty requested a review from Fei-Guo January 18, 2023 22:05
@helayoty helayoty temporarily deployed to test January 18, 2023 22:05 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 23:36 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 23:36 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 23:41 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 23:42 — with GitHub Actions Inactive
Fei-Guo
Fei-Guo reviewed Jan 19, 2023
View reviewed changes
cmd/init-container/main.go Outdated Show resolved Hide resolved
@helayoty
Roll back unrelated changes
037875a 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 19, 2023 03:26 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 19, 2023 03:27 — with GitHub Actions Inactive
@helayoty helayoty merged commit 1ee4191 into virtual-kubelet:master Jan 19, 2023
@helayoty helayoty deleted the init-container branch February 10, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request kind/feature
Projects
None yet
Milestone
1.4.10
Development

Successfully merging this pull request may close these issues.

Add network init container to the virtual kubelet deployment
3 participants
@helayoty @codecov-commenter @Fei-Guo