Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove custom code used by old Azure SDK - part 2 #423

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

helayoty
Copy link
Member

Remove the ContainerGroupWrapper that we used to send the extension property. As ACI SDK v2.2.2` implements it.

@helayoty helayoty temporarily deployed to test January 23, 2023 20:08 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 23, 2023 20:08 — with GitHub Actions Inactive
@helayoty helayoty mentioned this pull request Jan 23, 2023
3 tasks
@helayoty helayoty changed the title refactor: Remove custom code used by old Azure SDK refactor: Remove custom code used by old Azure SDK - part 2 Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #423 (91ab901) into master (0c76852) will increase coverage by 0.33%.
The diff coverage is 59.13%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   42.91%   43.24%   +0.33%     
==========================================
  Files          50       50              
  Lines        5735     5825      +90     
==========================================
+ Hits         2461     2519      +58     
- Misses       3017     3050      +33     
+ Partials      257      256       -1     
Impacted Files Coverage Δ
pkg/network/aci_network.go 25.92% <30.55%> (-0.61%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci.go 36.78% <58.82%> (+2.88%) ⬆️
pkg/provider/aci_volumes.go 45.19% <66.66%> (ø)
pkg/provider/containergroup_to_pod.go 75.39% <86.53%> (+0.11%) ⬆️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test January 23, 2023 20:32 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:15 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:15 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:21 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:21 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:23 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:23 — with GitHub Actions Inactive
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 24, 2023 03:25 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:25 — with GitHub Actions Inactive
@helayoty helayoty enabled auto-merge (squash) January 24, 2023 03:37
@helayoty helayoty merged commit 80d7d19 into virtual-kubelet:master Jan 24, 2023
@helayoty helayoty deleted the remove-custom-sdk branch January 24, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants