Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass buildversion variable via helm chart #463

Closed
wants to merge 1 commit into from

Conversation

helayoty
Copy link
Member

Fixes #360

signed-off-by: Heba Elayoty hebaelayoty@gmail.com

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test February 11, 2023 21:30 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 11, 2023 21:30 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 11, 2023 21:30 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #463 (e6992c2) into master (0c76852) will increase coverage by 1.25%.
The diff coverage is 51.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   42.91%   44.16%   +1.25%     
==========================================
  Files          50       50              
  Lines        5735     5898     +163     
==========================================
+ Hits         2461     2605     +144     
- Misses       3017     3038      +21     
+ Partials      257      255       -2     
Impacted Files Coverage Δ
pkg/featureflag/feature_flag.go 75.00% <ø> (+20.00%) ⬆️
pkg/network/aci_network.go 20.43% <7.74%> (-6.10%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci_volumes.go 45.19% <70.58%> (ø)
pkg/provider/aci.go 45.79% <76.74%> (+11.90%) ⬆️
pkg/provider/containergroup_to_pod.go 75.00% <85.71%> (-0.29%) ⬇️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty closed this Mar 1, 2023
@helayoty helayoty deleted the pass-buildversion branch October 4, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build version in vnode version
2 participants